Fix missing SIGKILL signal and mprof command in Windows#172
Merged
astrojuanlu merged 2 commits intopythonprofilers:masterfrom Nov 22, 2017
Merged
Fix missing SIGKILL signal and mprof command in Windows#172astrojuanlu merged 2 commits intopythonprofilers:masterfrom
astrojuanlu merged 2 commits intopythonprofilers:masterfrom
Conversation
bernizt
commented
Nov 21, 2017
bernizt
commented
- SIGKILL doesn't exist in Windows, but according to os.kill official Python doc any value should cause the process to be unconditionally killed, for example, -1.
- Simpler version of Fixes mprof windows installation #158, fixing issues unable to use mprof in windows 10, prompts 'How do you want to open this file?' #156 and mprof script not runnable on windows #75 without code duplication.
added 2 commits
November 21, 2017 13:42
Adds mprof.bat to python scripts so the mprof command can be executed
Collaborator
|
Thanks @bernizt ! This looks good to me. Any thoughts @Juanlu001 ? |
Collaborator
|
Looks good to me as well :) Merging! Thanks @bernizt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.